Hei hei, On Wed, Jul 13, 2022 at 02:50:14PM +0200, Michal Simek wrote: > > > On 7/13/22 14:33, Alexander Dahl wrote: > > From: Alexander Dahl <a...@thorsis.com> > > > WARNING: please write a paragraph that describes the config symbol fully > > We don't allow patches with empty commit message.
In general I would agree. However several of Tom's patches addressing kconfig migration have a commit message like this: This converts the following to Kconfig: FOO_BAR This is redundant to the subject saying exactly the same. I can add this if you want, but I saw no sense in it. > > > > > > Signed-off-by: Alexander Dahl <a...@thorsis.com> > > --- > > README | 4 ---- > > configs/astro_mcf5373l_defconfig | 1 + > > drivers/fpga/Kconfig | 6 ++++++ > > include/configs/astro_mcf5373l.h | 1 - > > scripts/config_whitelist.txt | 1 - > > Tom can confirm this but IIRC you don't need to remove this from this file. > Tom is doing sync up time to time. It is enough to do conversion only. This was done by the script ./tools/moveconfig.py where I just hit enter with defaults presented. The other Kconfig patches change defconfig, but not whitelist. Seems a little inconsistent to me. But I can remove that part, sure. Greets Alex > > M -- /"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
signature.asc
Description: PGP signature
