On Sun, Feb 13, 2022 at 9:10 PM Marek Vasut <ma...@denx.de> wrote: > > On 2/14/22 01:05, Adam Ford wrote: > > On Sat, Feb 12, 2022 at 8:26 AM Adam Ford <aford...@gmail.com> wrote: > >> > >> omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init > >> is only called by the probe function, so it can be static to that > >> function. Remove both from the header along with some additional > >> checking for DM_USB. > >> > > > > If it's not too late to hold off on this, I'd like to resend it as > > part of a larger series. I have a whole series based on this that > > converts the driver to use the phy subsystem in an effort to remove > > the OMAP_EHCI_PHYx_RESET_GPIO from Kconfig that makes the driver more > > device-tree friendly. Rather than doing this and waiting for the > > reviews, merge, etc. then doing the follow-up, I'd like to just send > > the series to avoid confusion as to any dependent patches. > > > > If it's too late, I'll just send the subsequent patches after this one > > gets reviewed and merged. > > It is not too late, but make sure you CC someone who can actually test > this EHCI OMAP stuff.
I have an OMAP35, DM37 and an AM3517 that I'll be using for testing the OMAP3's. So far it works on the DM3730. I haven't confirmed the others yet. I'll CC any of the maintainers for the defconfig files that enable the driver or OMAP_EHCI_PHYx_RESET_GPIO. adam
