Hello Simon > -----Original Message----- > From: Simon Glass <s...@chromium.org> > Sent: Wednesday, December 1, 2021 11:32 PM > To: Gaurav Jain <gaurav.j...@nxp.com> > Cc: u-boot@lists.denx.de; Stefano Babic <sba...@denx.de>; Fabio Estevam > <feste...@gmail.com>; Peng Fan <peng....@nxp.com>; Priyanka Jain > <priyanka.j...@nxp.com>; Ye Li <ye...@nxp.com>; Horia Geanta > <horia.gea...@nxp.com>; Ji Luo <ji....@nxp.com>; Franck Lenormand > <franck.lenorm...@nxp.com>; Silvano Di Ninno <silvano.dini...@nxp.com>; > Sahil Malhotra <sahil.malho...@nxp.com>; Pankaj Gupta > <pankaj.gu...@nxp.com>; Varun Sethi <v.se...@nxp.com>; dl-uboot-imx > <uboot-...@nxp.com>; Shengzhou Liu <shengzhou....@nxp.com>; Mingkai Hu > <mingkai...@nxp.com>; Rajesh Bhagat <rajesh.bha...@nxp.com>; Meenakshi > Aggarwal <meenakshi.aggar...@nxp.com>; Wasim Khan > <wasim.k...@nxp.com>; Alison Wang <alison.w...@nxp.com>; Pramod > Kumar <pramod.kuma...@nxp.com>; Andy Tang <andy.t...@nxp.com>; > Adrian Alonso <adrian.alo...@nxp.com>; Vladimir Oltean <olte...@gmail.com> > Subject: Re: [EXT] Re: [PATCH v6 01/15] crypto/fsl: Add support for CAAM Job > ring driver model > > Caution: EXT Email > > Hi Gaurav, > > On Wed, 1 Dec 2021 at 04:54, Gaurav Jain <gaurav.j...@nxp.com> wrote: > > > > Hello Simon, > > > > > -----Original Message----- > > > From: Simon Glass <s...@chromium.org> > > > Sent: Wednesday, December 1, 2021 11:57 AM > > > To: Gaurav Jain <gaurav.j...@nxp.com> > > > Cc: u-boot@lists.denx.de; Stefano Babic <sba...@denx.de>; Fabio > > > Estevam <feste...@gmail.com>; Peng Fan <peng....@nxp.com>; Priyanka > > > Jain <priyanka.j...@nxp.com>; Ye Li <ye...@nxp.com>; Horia Geanta > > > <horia.gea...@nxp.com>; Ji Luo <ji....@nxp.com>; Franck Lenormand > > > <franck.lenorm...@nxp.com>; Silvano Di Ninno > > > <silvano.dini...@nxp.com>; Sahil Malhotra <sahil.malho...@nxp.com>; > > > Pankaj Gupta <pankaj.gu...@nxp.com>; Varun Sethi <v.se...@nxp.com>; > > > dl-uboot-imx <uboot-...@nxp.com>; Shengzhou Liu > > > <shengzhou....@nxp.com>; Mingkai Hu <mingkai...@nxp.com>; Rajesh > > > Bhagat <rajesh.bha...@nxp.com>; Meenakshi Aggarwal > > > <meenakshi.aggar...@nxp.com>; Wasim Khan <wasim.k...@nxp.com>; > > > Alison Wang <alison.w...@nxp.com>; Pramod Kumar > > > <pramod.kuma...@nxp.com>; Andy Tang <andy.t...@nxp.com>; Adrian > > > Alonso <adrian.alo...@nxp.com>; Vladimir Oltean <olte...@gmail.com> > > > Subject: [EXT] Re: [PATCH v6 01/15] crypto/fsl: Add support for CAAM > > > Job ring driver model > > > > > > Caution: EXT Email > > > > > > Hi Gaurav, > > > > > > On Tue, 30 Nov 2021 at 03:41, Gaurav Jain <gaurav.j...@nxp.com> wrote: > > > > > > > > added device tree support for job ring driver. > > > > sec is initialized based on job ring information processed from > > > > device tree. > > > > > > > > Signed-off-by: Gaurav Jain <gaurav.j...@nxp.com> > > > > Reviewed-by: Ye Li <ye...@nxp.com> > > > > --- > > > > drivers/crypto/fsl/Kconfig | 7 + > > > > drivers/crypto/fsl/Makefile | 2 + > > > > drivers/crypto/fsl/jobdesc.c | 4 +- > > > > drivers/crypto/fsl/jr.c | 316 +++++++++++++++++++++++------------ > > > > drivers/crypto/fsl/jr.h | 14 ++ > > > > 5 files changed, 232 insertions(+), 111 deletions(-) > > > > > > Can you create a new uclass for this instead of using misc? What > > > operations does this device support? > > I am thinking of creating UCLASS_CAAM which will not be generic and > dedicated to job ring driver. > > Let me know if you are fine with this new uclass. > > This will support only single operation which is run(run_descriptor_jr) > > used to > enqueue the descriptor to JR. > > Let me know if you have any more comments, as I am planning to do validate > all the suggested changes on all imx, layerscape, powerpc platforms. > > > Well, have a look if remoteproc would suit you as it has > start()/stop() etc. But if not, yes creating your own uclass is fine. > You never know, others may use it. Remember to add a sandbox driver and test > (both are likely pretty trivial though).
On the second thought, JR driver operation run_descriptor_jr() can be implemented using the MISC class ioctl. will be floating the changes for review in next version soon. Regards Gaurav Jain > > Regards, > Simon
