Hi Fabio
On Sun, Nov 28, 2021 at 7:00 PM Fabio Estevam <feste...@gmail.com> wrote:
>
> Hi Michael,
>
> On Sun, Nov 28, 2021 at 1:58 PM Michael Nazzareno Trimarchi
> <mich...@amarulasolutions.com> wrote:
> >
> > Hi Fabio
> >
> > Any time to review it?
>
> Please fix the checkpatch warnings:
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75
> chars per line)
> #81:
> • Secondary boot is disabled if fuse value is bigger than 10, n = fuse
> value bigger than
>
> CHECK: Unnecessary parentheses around 'plat_config.misc_flags'
> #162: FILE: arch/arm/mach-imx/cmd_nandbcb.c:1540:
> + if ((plat_config.misc_flags) & FIRMWARE_SECONDARY_FIXED_ADDR) {
>
> total: 0 errors, 1 warnings, 1 checks, 65 lines checked
>
> I haven't personally touched arch/arm/mach-imx/cmd_nandbcb.c, so I would
> like to get a review from Ye Li or Han Xu, if possible.
Let's wait the other feedback and then I will upload the v3. I have
tried to stay on the same style
of that code section and I forgot to run checkpatch
Mcihael
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com
