On Tue, Nov 16, 2021 at 01:02:55AM +0100, Heinrich Schuchardt wrote: > On 11/16/21 00:51, AKASHI Takahiro wrote: > > > > Is the patch good enough to include in the series? > > > > > > > > If not, you could reply to it with what needs doing. > > ? I have already replied to your patch:) > > Basically, it seems to be fine to me. > > > > > > Regards, > > > > Simon > > > > > > > The patch is not usable as is. It assumes only GPT partioning is used. > > @Heinrich > > I don't get your point. Either my patch or Simon's is not specific > > to GPT at all. > > > > So I'm going to start respinning my patch for a next round of discussion. > > A field name gpt_part_info obviously relates to GPT?
No. IICU, the structure, disk_partition, is not particularly GPT-specific as such type of data are used over various partition drivers. In my patch series, I simply reuse "struct disk_part" as a structure holding a partition number and partition information (= disk_partition). -Takahiro Akashi > Up to now this string exists only in cmd/gpt.c. > > Best regards > > Heinrich > > > > > -Takahiro Akashi > > > > > Instead all partition table drivers need to be converted to drivers for > > > the new uclass. > > > > > > Best regards > > > > > > Heinrich >
