On Mon, Nov 1, 2021 at 11:25 PM Alper Nebi Yasak <alpernebiya...@gmail.com> wrote: > > Hi, > > I've had some recent success with my gru-kevin and wanted to update you > on this. Long story short, I can boot from SPI flash and have the > display, keyboard, eMMC, microSD card, USB disks all work (however with > some hacks); but can't boot into Linux. Things seem to hang shortly > after "Starting kernel..." but I don't know if something fails in U-Boot > or if I get a kernel panic. (I still have no serial console).
I suspect you need the following patch [1], we had the same hang in Fedora and even with a serial console and a whole bunch of kernel debug it was difficult to get to the bottom of. Sadly the fix, whether this patch or another one is still not upstream. [1] http://patchwork.ozlabs.org/project/uboot/patch/20210406151059.1187379-1-icen...@aosc.io/ > There are three relevant branches on my GitHub repo now, please have a > look. The first is for what I intend to send upstream soon enough. The > other two include hacks and additional patches that build on top of the > first, meant to improve things on a per-board basis: > > https://github.com/alpernebbi/u-boot/tree/rk3399-gru-chromebooks > https://github.com/alpernebbi/u-boot/tree/rk3399-gru-kevin > https://github.com/alpernebbi/u-boot/tree/rk3399-gru-bob > > I have no idea if the gru-bob versions work. I just thought things I did > for gru-kevin are applicable to it as well and decided I should include > them in case anyone wants to test. > > > I also want to ask you some things I'm indecisive about, before posting > the rk3399-gru-chromebooks branch as patches. > > Most of the patches are small config and dts changes that I've grouped > by whatever effect they have. Should I squash them into one commit each > for config/dts? > > Simon, I've edited some of your patches and kept you as author & > sign-off. Are you OK with the edited versions, am I doing things right? See: > > > https://github.com/alpernebbi/u-boot/commit/8c658b7811f4324cd699bd035e802f9339efa8f7 > > https://github.com/alpernebbi/u-boot/commit/c2c68f23e10a51b8d34c00764a33fc847d785f60 > > https://github.com/alpernebbi/u-boot/commit/995454193906e04bfb4e0e38f2bf1a18634a1ebf > > Marty, your (second) chromebook_kevin support patch didn't have your > sign-off. Is it OK to add it? See: > > > https://github.com/alpernebbi/u-boot/commit/4cee351e012dc26714640e868069b5cc4b5a8329 > > I also think I should squash my gru-kevin changes into that commit, add > a commit message about board status, and keep Marty as author & sign-off > while adding myself as Co-authored-by & sign-off. Any better ideas on > how to structure the patches? > > Do both of you want to be in /board/google/gru/MAINTAINERS? I have three > of us listed there right now, but no idea if that's fine with you two. > > Hope you can spare time on this.