Re: [U-Boot] [PATCH 1/2] use MAC from environment and add support for new NET_MULTI api in ethernet driver of KS8695

[Mike Frysinger]

On Thursday, November 04, 2010 06:13:00 Bernstein, Michael wrote:
> diff --unified --recursive --new-file
> u-boot-2009.11/drivers/net/ks8695eth.c
> u-boot-2009.11,new/drivers/net/ks8695eth.c ---
> u-boot-2009.11/drivers/net/ks8695eth.c

this is a pretty old tree.  you should be using latest mainline tree.

>  void ks8695_getmac(void)
>  {
> -       unsigned char *fp;
> -       int i;
> +       if (!eth_getenv_enetaddr("ethaddr", &eth_mac[0])) {

NAK.  drivers should not be poking the environment.  please read the 
documentation in doc/README.drivers.eth.
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot