Hi Heinrich, On Thu, 9 Sep 2021, 10:25 Heinrich Schuchardt, <[email protected]> wrote: > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 8 Sept 2021 at 11:27, Heinrich Schuchardt <[email protected]> > > wrote: > >> > >> > >> > >> On 9/8/21 3:33 PM, Simon Glass wrote: > >>> The setup routines are called from zimage but don't really belong in the > >>> zimage header. Add a new EFI header to house these. Add comments so it is > >>> clear what the functions do. > >>> > >>> Signed-off-by: Simon Glass <[email protected]> > >>> --- > >>> > >>> arch/x86/include/asm/efi.h | 32 ++++++++++++++++++++++++++++++++ > >>> arch/x86/include/asm/zimage.h | 3 --- > >>> arch/x86/lib/zimage.c | 1 + > >>> 3 files changed, 33 insertions(+), 3 deletions(-) > >>> create mode 100644 arch/x86/include/asm/efi.h > >> > >> In the future we should be able to run the EFI app on any UEFI > >> architecture. Given this background are the function definitions really > >> x86 specific? > > > > Well firstly that seems like that would be future work for someone. > > I did not expect that you do that work. But we should not make that work > more difficult than necessary. > > > Secondly, this relates to zimage which is really only used by x86 as > > far as I am aware. > > setup_video() and setup_efi_info() do not sound like zImage nor like x86 > specific.
But actually they are. Please can you take a closer look? This is just using existing code... Regards, Simon
