On Monday 02 August 2021 15:18:27 Pali Rohár wrote: > Including timestamp.h (either directly or transitionally) cause build > system to recompile binaries at every 'make' run. This has disadvantage > in U-Boot development as for every small change 'make' recompiles lot of > other irrelevant files which were not touched / changed. > > This patch series eliminate transitional / indirect usage of > timestamp.h by removing unneeded inclusion of header files, moving > timestamp values from macros to global variables, etc... > > After these patches, U-Boot tools are not recompiled by every 'make' run, > which decrease time for incremental U-Boot recompilation. > > Please test these patches, specially m68k and powerpc parts as I do not > have any of these boards. > > Patch series depend on this patch (now marked as accepted): > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/
Hello! Is there anything else needed for this patch series? > Pali Rohár (11): > Remove #include <timestamp.h> from files which do not need it > Remove #include <version.h> from files which do not need it > efi_loader: Use directly version_string variable > version: Move version_string[] from version.h to version_string.h > m68k: mcf: Remove overloading version_string > version: Put version_string[] variable into section > .text_version_string > powerpc: mpc: Put U-Boot version string at correct place by linker > script > version: Do not make version_string[] variable as a weak > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > version: Remove global macro U_BOOT_VERSION_STRING from version.h > Remove including timestamp.h in version.h > > arch/arm/mach-rockchip/px30-board-tpl.c | 1 - > arch/arm/mach-rockchip/tpl.c | 4 ++++ > arch/m68k/cpu/mcf5227x/start.S | 6 ------ > arch/m68k/cpu/mcf523x/start.S | 6 ------ > arch/m68k/cpu/mcf52x2/start.S | 6 ------ > arch/m68k/cpu/mcf530x/start.S | 8 ------- > arch/m68k/cpu/mcf532x/start.S | 6 ------ > arch/m68k/cpu/mcf5445x/start.S | 7 ------- > arch/nios2/cpu/start.S | 1 - > arch/powerpc/cpu/mpc83xx/start.S | 10 +++------ > arch/powerpc/cpu/mpc83xx/u-boot.lds | 3 +++ > arch/powerpc/cpu/mpc85xx/start.S | 10 ++++----- > arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 4 ++++ > arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 4 ++++ > arch/powerpc/cpu/mpc85xx/u-boot.lds | 4 ++++ > arch/powerpc/cpu/mpc8xx/start.S | 9 ++++---- > arch/x86/cpu/quark/mrc.c | 4 +--- > arch/x86/lib/acpi_table.c | 1 - > board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c | 1 - > board/cssi/MCR3000/u-boot.lds | 2 ++ > board/ge/b1x5v2/b1x5v2.c | 2 +- > board/ge/bx50v3/bx50v3.c | 2 +- > board/ge/mx53ppd/mx53ppd.c | 2 +- > board/l+g/vinco/vinco.c | 1 - > board/renesas/grpeach/lowlevel_init.S | 1 - > .../work_92105/work_92105_display.c | 1 + > cmd/version.c | 7 ++++++- > common/main.c | 2 +- > common/spl/spl.c | 4 ++++ > doc/develop/version.rst | 21 +++++++++++-------- > drivers/rtc/emul_rtc.c | 2 +- > drivers/usb/gadget/f_rockusb.c | 1 - > drivers/video/cfb_console.c | 3 +-- > include/configs/bcmstb.h | 1 - > include/version.h | 8 ------- > include/version_string.h | 8 +++++++ > lib/display_options.c | 2 +- > lib/efi_loader/efi_tcg2.c | 7 +++---- > net/cdp.c | 3 --- > test/print_ut.c | 2 +- > 40 files changed, 75 insertions(+), 102 deletions(-) > create mode 100644 include/version_string.h > > -- > 2.20.1 >
