Re: [PATCH 3/7] xyz-modem: Put xyzModem_stream_close debug diagnostic message into ZM_DEBUG()

[Heinrich Schuchardt]

On 03.08.21 16:28, Pali Rohár wrote:

This is how all other debug / diagnostic messages are handled.

This commit message is misleading. What you do is hide an output.

Signed-off-by: Pali Rohár <p...@kernel.org>
---
  common/xyzModem.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/xyzModem.c b/common/xyzModem.c
index 631c44e11adf..c200c9ff9177 100644
--- a/common/xyzModem.c
+++ b/common/xyzModem.c
@@ -608,10 +608,10 @@ xyzModem_stream_read (char *buf, int size, int *err)
  void
  xyzModem_stream_close (int *err)
  {
-  diag_printf
+  ZM_DEBUG (zm_dprintf
      ("xyzModem - %s mode, %d(SOH)/%d(STX)/%d(CAN) packets, %d retries\n",
       xyz.crc_mode ? "CRC" : "Cksum", xyz.total_SOH, xyz.total_STX,
-     xyz.total_CAN, xyz.total_retries);
+     xyz.total_CAN, xyz.total_retries));
    ZM_DEBUG (zm_flush ());

zm_dprintf prints into the debug buffer which seems not to be overflow
protected.

diag_printf prints to the console.

Why do you want to hide this message?
Isn't the CRC what the user will want to check?
And if many retries occur doesn't this alert the user that the transfer
may be corrupted?

Best regards

Heinrich

  }