On Thu, Jun 03, 2021 at 05:07:17PM +0200, Rasmus Villemoes wrote: > On 03/06/2021 15.39, Tom Rini wrote: > > Based on the comment in socfpga_soc64_common.h, the intention is for > > CONFIG_SYS_MEM_RESERVE_SECURE to be unused. However, in the code we do: > > ... > > > > and that will evaluate to true. This leads to unwanted code being > > Some cleanup made lines beginning with # disappear? I can _strongly_ > recommend setting commit.cleanup to scissors; I have lost count of the > number of times I've had a commit message mangled and become practically > useless because important lines got removed. > > For example > <http://lists.busybox.net/pipermail/busybox/2018-September/086647.html> > became > <https://git.busybox.net/busybox/commit/?id=571e525a141a2de87b9c2ced485745e96418d921>
Bah! Yes, thanks. It should have said #ifdef CONFIG_SYS_MEM_RESERVE_SECURE ... #endif -- Tom
signature.asc
Description: PGP signature
