This saves some code, both in terms of #LOC and .text size, and it is
also the normal convention that foo(...) is implemented in terms of
vfoo().

Reviewed-by: Simon Glass <s...@chromium.org>
Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk>
---
 lib/vsprintf.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 9dc96c81c6..cf3982eb03 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -787,22 +787,11 @@ int printf(const char *fmt, ...)
 {
        va_list args;
        uint i;
-       char printbuffer[CONFIG_SYS_PBSIZE];
 
        va_start(args, fmt);
-
-       /*
-        * For this to work, printbuffer must be larger than
-        * anything we ever want to print.
-        */
-       i = vscnprintf(printbuffer, sizeof(printbuffer), fmt, args);
+       i = vprintf(fmt, args);
        va_end(args);
 
-       /* Handle error */
-       if (i <= 0)
-               return i;
-       /* Print the string */
-       puts(printbuffer);
        return i;
 }
 
-- 
2.31.1

Reply via email to