On Sat, Mar 20, 2021 at 02:59:05PM +1300, Simon Glass wrote: > Hi Tom, > > On Sat, 20 Mar 2021 at 14:06, Tom Rini <tr...@konsulko.com> wrote: > > > > On Sat, Mar 20, 2021 at 12:54:00PM +1300, Simon Glass wrote: > > > On Sat, 20 Mar 2021 at 09:42, Tom Rini <tr...@konsulko.com> wrote: > > > > > > > > On Tue, Mar 16, 2021 at 09:51:44PM +0100, Dario Binacchi wrote: > > > > > > > > > The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, > > > > > but > > > > > it is not allowed. This breaks of-platdata and makes the result > > > > > non-deterministic. > > > > > > > > > > The driver does not need to be an uclass driver, so lets remove it. I > > > > > had turned it into an uclass driver because I thought wrongly it had > > > > > to > > > > > call the dm_scan_fdt_dev routine to work properly, but some tests on > > > > > the > > > > > board have shown otherwise. > > > > > > > > > > Signed-off-by: Dario Binacchi <dario...@libero.it> > > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > > > > > Applied to u-boot/master, thanks! > > > > > > Also applied to u-boot-dm/next, thanks! > > > > Well, wait, no, why? -rc5 will get merged to -next in time I hope. Is > > this going to block other work in dm/next? > > Ah I'm about to send a pull request which fails without this. I can > hold off if you like?
Ah, OK. git should do the right thing in the end, I hope. I'll do a quick local test to confirm once you send me the PR. -- Tom
signature.asc
Description: PGP signature