Hi Asherah, On Mon, 22 Feb 2021 at 02:12, Asherah Connor <a...@kivikakk.ee> wrote: > > Hi Tom, Simon; > > On 21/02/20 05:02:p, Tom Rini wrote: > > On Sat, Feb 20, 2021 at 04:54:41AM -0700, Simon Glass wrote: > > > Probably create a uclass. I expect there are operations and some > > > private data. We also need to think about testing, since all uclasses > > > need a sandbox test. > > > > Well, need a test. Since this is something for qemu, which is already a > > virtual platform, I'd be quite happy to see this tested in the qemu > > platforms that will support it and then not sandbox. > > I've completed the rewrite to uclass and will be sending the next > version of the patch series along shortly. I'm now looking to complete > the tests. > > Tom, what do you have in mind when you say "see this tested in the qemu > platforms that will support it"? It looks like we don't have any > existing tests that use qemu, with the exception of > test/nokia_rx51_test.sh, which doesn't look like anything to pattern > from. > > A simple sandbox test in test/dm looks like it shouldn't be much work, > if it's ideal.
Yes I would encourage that since it will be covered by the common 'make qcheck' case in local testing and is therefore easy for people to run and debug. Regards, Simon
