On Sat, Feb 20, 2021 at 04:54:41AM -0700, Simon Glass wrote: > Hi Asherah, > > On Fri, 19 Feb 2021 at 18:14, Asherah Connor <a...@kivikakk.ee> wrote: > > > > On 21/02/19 06:02:p, Heinrich Schuchardt wrote: > > > drivers/misc/qfw.c should be converted to the driver model instead of > > > initializing the driver in arch_early_init_r() on qemu-arm and > > > qemu_chipset_init() on qemu-x86. > > > > > > Cf. https://u-boot.readthedocs.io/en/latest/driver-model/index.html > > > > > > Please, coordinate the change with Simon. > > > > Understood. I've played around a little bit with the DM and it > > shouldn't be too hard to convert. Probably the biggest question in my > > mind is, should it be slotted into UCLASS_MISC? Or do we create a qfw > > uclass? > > Probably create a uclass. I expect there are operations and some > private data. We also need to think about testing, since all uclasses > need a sandbox test.
Well, need a test. Since this is something for qemu, which is already a virtual platform, I'd be quite happy to see this tested in the qemu platforms that will support it and then not sandbox. -- Tom
signature.asc
Description: PGP signature
