On 2/3/21 10:41 PM, Marek Behun wrote:
> On Wed, 3 Feb 2021 08:32:45 +0900
> Jaehoon Chung <jh80.ch...@samsung.com> wrote:
>
>> On 2/3/21 2:37 AM, Marek Behún wrote:
>>> This is needed to parse more capabilities such as `non-removable`.
>>>
>>> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
>>> a regression on Turris Omnia, because mv_sdhci driver did not fill out
>>> host_caps from device-tree.
>>>
>>> Signed-off-by: Marek Behún <marek.be...@nic.cz>
>>> Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
>>
>> I don't think that this patch is for fixing its commit.
>>
>> Best Regards,
>> Jaehoon Chung
>
> Commit da18c62b6e6a causes the regression. The Fixes tag, as I
> understand, should link to commit with which the regression first
> occured, so that if someone wanted to backport my patch to previous
> version of U-Boot, they would know that they only have to do it if
> their repository contains that commit.
Well, i don't think so. This patch is not a bug fix patch about commit
da18c62b6e6a.
Just mv_sdhci driver didn't use mmc_of_parse() before.
(If someone set to MMC_NON_REMOVABLE capabilities in host->cap, it should be
working.)
Not need to add *Fixes*. Its commit is a generic callback function.
And mmc_of_parse() is also generic function to use Driver-model.
Best Regards,
Jaehoon Chung
>
> Marek
>
