Hi Marek, On Sun, Jan 24, 2021 at 4:52 PM Marek Vasut <ma...@denx.de> wrote: > > On 1/24/21 3:35 PM, Oleksandr Suvorov wrote: > > On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic <sba...@denx.de> wrote: > >> > >> Hi Marek, > >> > >> On 23.01.21 20:57, Marek Vasut wrote: > >>> On 1/23/21 8:54 PM, sba...@denx.de wrote: > >>>>> The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which > >>>>> supports OF control, correctly set the rgmii-id PHY mode in the DT and > >>>>> then determine whether or not to enable the FEC RXC/TXC internal delay > >>>>> based on the PHY mode. > >>> > >>> [...] > >>> > >>>> Applied to u-boot-imx, master, thanks ! > >>> > >>> Didn't this fail to build on mx25 ? > >> > >> Yes, sorry, this is a false positive - patch has not been applied. > > > > Anyway, as there will be another solution that won't break mx25/mx35, > > I should retest the new patch version on apalis, so I'm calling off my > > review so far. > > The only change required to that patch is an extra ifdef DM_ETH, so for > mx8 apalis nothing changed, since you have DM_ETH enabled.
Thanks for clarifying! So you have my review for apalis mx8. -- Best regards Oleksandr Suvorov cryo...@gmail.com
