On Mon, Oct 4, 2010 at 9:21 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Graeme Russ, > > In message <4ca9a70b.6030...@gmail.com> you wrote: >> >> >> +#if CONFIG_SYS_SDRAM_ECC_ENABLE >> >> + /* Skip ECC initialization if not starting from cold-reset */ >> >> + movl %ebx, %ecx >> >> + andl $GD_FLG_COLD_BOOT, %ecx >> >> + jz ecc_init_ret >> > >> > But the label you added is called 'init_ecc_ret'. Are you sure the >> > name is correct here? >> >> Yes, if the board has not been cold-booted (i.e. a new U-Boot image has >> been loaded into RAM and executed) we must skip ECC initialization (it >> destroys the contents of memory) >> >> > >> >> + mov $init_ecc_ret, %ebp >> >> + jmp init_ecc >> >> + >> >> +init_ecc_ret: > > Sergei did not question the code itself, but the possible confusion > between "ecc_init_ret" versus "init_ecc_ret", which both were added > with the same commit, so it seems likely both should actually be the > _same_ name? >
Ah yes, now I see - thanks for picking this up. Will fix before applying Regards, Graeme _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
