On Wed, 2020-12-09 at 17:30 +0100, Nicolas Saenz Julienne wrote:
> On Wed, 2020-12-09 at 13:58 +0100, Matthias Brugger wrote:
> [...]
> > > +
> > > + /* switch to that node */
> > > + parent = of_get_parent(dev);
> > > + if (!parent) {
> > > + printf("Found dma-ranges in root node, shoudln't happen\n");
> > > + ret = -EINVAL;
> > > + goto out;
> > > + }
> >
> > Aren't we missing a of_node_put(parent) here?
>
> Yes, that's right.
Actually I now see why I didn't do it, as there is no need:
/* Dummy functions to mirror Linux. These are not used in U-Boot */
#define of_node_get(x) (x)
static inline void of_node_put(const struct device_node *np) { }
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
