Hi, On Tue, 24 Nov 2020 at 06:23, Tom Rini <tr...@konsulko.com> wrote: > > On Tue, Nov 24, 2020 at 12:41:34PM +0000, Pragnesh Patel wrote: > > > > > > >-----Original Message----- > > >From: Tom Rini <tr...@konsulko.com> > > >Sent: 23 November 2020 21:22 > > >To: Pragnesh Patel <pragnesh.pa...@openfive.com> > > >Cc: u-boot@lists.denx.de; atish.pa...@wdc.com; palmerdabb...@google.com; > > >bmeng...@gmail.com; Paul Walmsley ( Sifive) <paul.walms...@sifive.com>; > > >anup.pa...@wdc.com; Sagar Kadam <sagar.ka...@openfive.com>; > > >r...@andestech.com; Simon Glass <s...@chromium.org>; Heinrich Schuchardt > > ><xypron.g...@gmx.de>; Bin Meng <bin.m...@windriver.com>; Miquel Raynal > > ><miquel.ray...@bootlin.com>; Patrick Delaunay <patrick.delau...@st.com>; > > >Sam Protsenko <joe.s...@gmail.com>; Philippe Reynes > > ><philippe.rey...@softathome.com>; Frédéric Danis > > ><frederic.da...@collabora.com>; Patrice Chotard <patrice.chot...@st.com>; > > >Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com>; Ramon Fried > > ><rfried....@gmail.com>; Eugeniu Rosca <roscaeuge...@gmail.com> > > >Subject: Re: [PATCH] cmd: Add a pwm command > > > > > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > > > > > >> Add the command "pwm" for controlling the pwm channels. This command > > >> provides pwm invert/config/enable/disable functionalities via PWM > > >> uclass drivers > > >> > > >> Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com> > > >> --- > > >> cmd/Kconfig | 6 +++ > > >> cmd/Makefile | 1 + > > >> cmd/pwm.c | 119 > > >+++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> 3 files changed, 126 insertions(+) > > >> create mode 100644 cmd/pwm.c > > > > > >Can you please add some tests and dt fragments to sandbox for this? > > > > There is already a "test/dm/pwm.c". > > Right, but for the new command as well please, similar to > test/py/tests/test_gpio.py.
I would be happier with a C test like [1] as it is faster and allows debugging, etc. Regards, Simon [1] test/cmd/mem_search.c
