Hi Rick, >-----Original Message----- >From: Rick Chen <rickche...@gmail.com> >Sent: 13 November 2020 12:47 >To: Pragnesh Patel <pragnesh.pa...@openfive.com> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra ><atish.pa...@wdc.com>; palmerdabb...@google.com; Bin Meng ><bmeng...@gmail.com>; Paul Walmsley ( Sifive) <paul.walms...@sifive.com>; >Anup Patel <anup.pa...@wdc.com>; Sagar Kadam ><sagar.ka...@openfive.com>; rick <r...@andestech.com>; Alan Kao ><alan...@andestech.com>; Leo Liang <ycli...@andestech.com> >Subject: Re: [PATCH v2 1/2] i2c: ocores: add i2c driver for OpenCores I2C >controller > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >Hi Pragnesh > >> > From: Pragnesh Patel [mailto:pragnesh.pa...@sifive.com] >> > Sent: Thursday, October 22, 2020 2:55 PM >> > To: u-boot@lists.denx.de >> > Cc: atish.pa...@wdc.com; palmerdabb...@google.com; >> > bmeng...@gmail.com; paul.walms...@sifive.com; anup.pa...@wdc.com; >> > sagar.ka...@sifive.com; Rick Jian-Zhi Chen(陳建志); >> > pe...@korsgaard.com; Pragnesh Patel; Heiko Schocher >> > Subject: [PATCH v2 1/2] i2c: ocores: add i2c driver for OpenCores >> > I2C controller >> > >> > Add support for the OpenCores I2C controller IP core (See >> > http://www.opencores.org/projects.cgi/web/i2c/overview). >> > >> > This driver implementation is inspired from the Linux OpenCores I2C >> > driver available. >> > >> > Thanks to Peter Korsgaard <pe...@korsgaard.com> for writing Linux >> > OpenCores I2C driver. >> > >> > Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com> >> > --- >> > >> > Changes in v2: >> > - Remove TYPE_SIFIVE_REV0 flag >> > - Update the Opencores I2C Controller Link >> > >> > drivers/i2c/Kconfig | 7 + >> > drivers/i2c/Makefile | 1 + >> > drivers/i2c/ocores_i2c.c | 636 >> > +++++++++++++++++++++++++++++++++++++++ >> > 3 files changed, 644 insertions(+) >> > create mode 100644 drivers/i2c/ocores_i2c.c >> > >> >> Reviewed-by: Rick Chen <r...@andestech.com> > >Please check the CI failure item: >https://travis-ci.org/github/rickchen36/u-boot-riscv/jobs/743114190 > >+drivers/i2c/ocores_i2c.c: In function 'ocores_i2c_probe': >1291+drivers/i2c/ocores_i2c.c:523:4: error: implicit declaration of >function 'dev_err' [-Werror=implicit-function-declaration] >1292+ 523 | dev_err(dev, >1293+ | ^~~~~~~ >1294+drivers/i2c/ocores_i2c.c:528:4: error: implicit declaration of >function 'dev_warn' [-Werror=implicit-function-declaration] >1295+ 528 | dev_warn(dev, >1296+ | ^~~~~~~~ >1297+cc1: all warnings being treated as errors > >Thanks, >Rick
Will rebase and send it again.
