Re: [PATCH U-BOOT v3 03/30] fs: btrfs: Crossport btrfs_read_dev_super() from btrfs-progs

[Tom Rini]

On Wed, Jun 24, 2020 at 06:02:49PM +0200, Marek Behún wrote:

> From: Qu Wenruo <w...@suse.com>
> 
> This patch uses generic code from btrfs-progs to read one super block
> from block device.
[snip]
> +/* Provide a compatibility layer to make code syncing easier */
> +
> +/* A simple wraper to for error() used in btrfs-progs */
> +__attribute__((format (__printf__, 1, 2)))
> +static inline void error(const char *fmt, ...)
> +{
> +     printf("BTRFS: ");
> +     printf(fmt, __builtin_va_arg_pack());
> +     printf("\n");
> +}

Note that this does not work with LLVM (no __builtin_va_arg_pack()).
I'm reworking this call pr_err(...) under the hood instead, with "BTRFS: " 
included in the message.

-- 
Tom

signature.asc
Description: PGP signature