On 09/07/2020 19.51, Joao Marcos Costa wrote: > Add support for SquashFS filesystem. Right now, it does not support > compression but support for zlib will be added in a follow-up commit.
Cool, thanks for proposing this. While I'm not really in a position to review these, just one comment below. > > +config SPL_FS_SQUASHFS > + bool "Support SquashFS filesystems" > + select FS_SQUASHFS Is there any reason U-Boot proper must support squashfs if the SPL does? This isn't quite specific to this patch; I see a number of 'config SPL_FOO' that either depends on or selects FOO (e.g. SPL_FS_FAT), and I wonder why. Rasmus
