On Fri, 12 Jun 2020 at 18:23, Zhiqiang Hou <zhiqiang....@nxp.com> wrote:
>
> From: Hou Zhiqiang <zhiqiang....@nxp.com>
>
> The board_eth_init() is only used by legacy ethernet driver framework,
> so do not compile it when DM_ETH config has been selected.
>
> Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com>
> ---
Ideally shouldn't all p1010rdb configs be converted to DM_ETH, and
then board_eth_init can be deleted? What was the problem with the rest
of the configs?
> V3:
> - Rebase the patch, no change intended.
>
> board/freescale/p1010rdb/p1010rdb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/freescale/p1010rdb/p1010rdb.c
> b/board/freescale/p1010rdb/p1010rdb.c
> index 66ccc0bd1e..309f4daa88 100644
> --- a/board/freescale/p1010rdb/p1010rdb.c
> +++ b/board/freescale/p1010rdb/p1010rdb.c
> @@ -484,6 +484,7 @@ int checkboard(void)
> return 0;
> }
>
> +#ifndef CONFIG_DM_ETH
> int board_eth_init(bd_t *bis)
> {
> #ifdef CONFIG_TSEC_ENET
> @@ -524,6 +525,7 @@ int board_eth_init(bd_t *bis)
>
> return pci_eth_init(bis);
> }
> +#endif
>
> #if defined(CONFIG_OF_BOARD_SETUP)
> void fdt_del_flexcan(void *blob)
> --
> 2.25.1
>
