On 6/12/20 10:01 AM, Nico Becker wrote:
[...]
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 9900b44274..2e815ca5f0 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -356,6 +356,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \
> socfpga_cyclone5_socrates.dtb \
> socfpga_cyclone5_sr1500.dtb \
> socfpga_cyclone5_vining_fpga.dtb \
> + socfpga_cyclone5_ica_moritz_iii.dtb \
Please keep the list sorted.
> socfpga_stratix10_socdk.dtb
>
> dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb \
> diff --git a/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii-u-boot.dtsi
> b/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii-u-boot.dtsi
> new file mode 100644
> index 0000000000..3ba01d1fd9
> --- /dev/null
> +++ b/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii-u-boot.dtsi
> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * U-Boot additions
> + *
> + * Copyright (C) 2012 Altera Corporation <www.altera.com>
> + * Copyright (c) 2018 Simon Goldschmidt
Are you sure about this copyright information ?
[...]
> diff --git a/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii.dts
> b/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii.dts
> new file mode 100644
> index 0000000000..7836ecc8b6
> --- /dev/null
> +++ b/arch/arm/dts/socfpga_cyclone5_ica_moritz_iii.dts
> @@ -0,0 +1,122 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2012 Altera Corporation <www.altera.com>
> + */
> +
> +#include "socfpga_cyclone5.dtsi"
> +
> +/ {
> + model = "ic-automation Moritz III";
> + compatible = "ic-automation,moritz_iii", "altr,socfpga-cyclone5",
Use tabs to indent. ./scripts/checkpatch.pl should tell you that, so run
it before sending V2. Now I get:
total: 60 errors, 31 warnings, 30 checks, 1794 lines checked
[...]
> diff --git a/board/ic-automation/moritz_iii/MAINTAINERS
> b/board/ic-automation/moritz_iii/MAINTAINERS
> new file mode 100644
> index 0000000000..29e705524e
> --- /dev/null
> +++ b/board/ic-automation/moritz_iii/MAINTAINERS
> @@ -0,0 +1,8 @@
> +MORITZ III BOARD
> +M: Nico Becker <n.bec...@ic-automation.de>
> +S: Maintained
> +F: board/ic-automation/moritz_iii/
> +F: include/configs/socfpga_ica_moritz_iii.h
> +F: configs/socfpga_moritz_iii_defconfig
> +F: arch/arm/dts/socfpga_cyclone5_ica_moritz_iii.dts
> +F: arch/arm/dts/socfpga_cyclone5_ica_moritz_iii-u-boot.dtsi
Indent seems wrong, please use tabs consistently.
[...]
