On Fri, Aug 27, 2010 at 5:46 PM, Scott Wood <scottw...@freescale.com> wrote: > On 08/27/2010 04:36 PM, Ben Gardiner wrote: >> >> On Fri, Aug 27, 2010 at 9:51 AM, Ben Gardiner >> <bengardi...@nanometrics.ca> wrote: >> But since a board may have NAND enabled but not MTD_DEVICE (i.e. guruplug) >> I get >> link errors sometimes. > > Grr... Eventually we ought to make NAND depend on MTD_DEVICE. It's 808 > bytes currently in my build, but if we could get rid of/reduce specialized > client code, it could more than make up for it. > > For now, I guess don't worry about sharing the code.
Ok -- thanks, Scott. I'll re-spin on Monday. >> ATM I'm thinking of leaving the original >> implementation of get_len_incl_bad in an #else. An alternative is to >> move 'mtdparts spread' to 'nand mtdparts.spread' -- only OneNAND and >> NAND devices (currently) have bad_block functions. > > There's too much duplication between NAND and OneNAND as is; I'd rather do > it at the MTD layer. Whew -- I'm glad I don't have to migrate all of the patches to new files. :) Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
