Hi Masahiro,
On Tue, 19 May 2020 at 21:32, Masahiro Yamada
<yamada.masah...@socionext.com> wrote:
>
> I do not understand the change made to this file by
> commit 90526e9fbac4 ("common: Drop net.h from common header").
>
> git show 90526e9fbac4 -- arch/arm/mach-uniphier/arm32/psci.c
>
> It added <asm/cache.h> while this file does not call the standard cache
> functions at all.
>
> All the uniphier-specific cache functions, uniphier_cache_*() are
> declared in cache-uniphier.h, which is already included from this file.
>
> Including <asm/system.h> is sensible to fix the -Wmissing-prototypes
> warnings because this file defines psci_cpu_on and psci_system_reset().
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> ---
>
> arch/arm/mach-uniphier/arm32/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I suspect it is a limitation of my scripting, which is not perfect. It
should rely more on ctags, etc. than grep/
Reviewed-by: Simon Glass <s...@chromium.org>
Regards,
Simon
