Hi Simon, On Tue, May 12, 2020 at 3:35 PM Bernhard Messerklinger <bernhard.messerklin...@br-automation.com> wrote: > > A the moment the FSP-M configuration is a mix of hard coded values and > devicetree properties. > This patch makes FSP-M full configurable from devicetree by adding > binding properties for all FSP-M parameters. > Co-developed-by: Wolfgang Wallner <wolfgang.wall...@br-automation.com> > Signed-off-by: Wolfgang Wallner <wolfgang.wall...@br-automation.com> > Signed-off-by: Bernhard Messerklinger > <bernhard.messerklin...@br-automation.com> > > --- > > Changes in v3: > Enable fspm,dual-rank-support-enable on chromebook coral > Split patch into FSP-M and FSP-S > > Changes in v2: None > > arch/x86/cpu/apollolake/Makefile | 1 + > arch/x86/cpu/apollolake/fsp_bindings.c | 614 ++++++++++++++++++ > arch/x86/cpu/apollolake/fsp_m.c | 169 +---- > arch/x86/dts/chromebook_coral.dts | 38 +- > .../asm/arch-apollolake/fsp/fsp_m_upd.h | 168 +++++ > .../asm/arch-apollolake/fsp_bindings.h | 96 +++ > .../fsp/fsp2/apollolake/fsp-m.txt | 320 +++++++++ > 7 files changed, 1242 insertions(+), 164 deletions(-) > create mode 100644 arch/x86/cpu/apollolake/fsp_bindings.c > create mode 100644 arch/x86/include/asm/arch-apollolake/fsp_bindings.h > create mode 100644 doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-m.txt >
Could you please give a "Reviewed-by" or "Tested-by"? Regards, Bin