Dear ratbert.chu...@gmail.com,
In message <1274771093-29677-1-git-send-email-ratbert.chu...@gmail.com> you
wrote:
> From: Po-Yu Chuang <ratb...@faraday-tech.com>
>
>
> Signed-off-by: Po-Yu Chuang <ratb...@faraday-tech.com>
> ---
> common/memsize.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/common/memsize.c b/common/memsize.c
> index 6c275c9..99469ab 100644
> --- a/common/memsize.c
> +++ b/common/memsize.c
> @@ -74,6 +74,7 @@ long get_ram_size(volatile long *base, long maxsize)
> return (0);
> }
>
> + *addr = save[i];
> for (cnt = 1; cnt < maxsize / sizeof (long); cnt <<= 1) {
> addr = base + cnt; /* pointer arith! */
> val = *addr;
I think this patch is wrong. The value at address (base + 0) is never
saved, so there is no need to restore it (nor did we store it's value
anywhere).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The important thing about being a leader is not being right or wrong,
but being *certain*. - Terry Pratchett, _Truckers_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
