Thanks Stefan. On 2/13/20 10:21 AM, Stefan wrote: > On 13.02.20 10:18, Mauro Condarelli wrote: >> Thanks Stefan. >> >> On 2/13/20 7:50 AM, Stefan wrote: >>> On 12.02.20 16:30, Mauro Condarelli wrote: >>>> Small patch series to add support for VoCore/VoCore2 board. >>>> >>>> VoCore is open hardware and runs OpenWrt/LEDE. >>>> It has WIFI, USB, UART, 20+ GPIOs but is only one inch square. >>>> It will help you to make a smart house, study embedded system >>>> or even make the tiniest router in the world. >>>> >>>> Details about this SoM can be found at "https://vocore.io/v2.html";. >>>> >>>> Signed-off-by: Mauro Condarelli <mc5...@mclink.it> >>>> --- >>>> >>>> Changes in v5: >>>> - Removed unneeded (and wrong) UART2 initialization in board.c >>>> - Added network setup. >>>> - Removed project-specific code. >>>> - Move back environment to SPI NOR. >>>> - Changes to environment default settings. >>>> - Rebase on current u-boot-mips/testing >>>> >>>> Changes in v4: >>>> - Reverted some overzealous DTS cleaning. >>>> - Added support for bootcount >>>> >>>> Changes in v3: >>>> - based on top of Weijie Gao patchset: >>>> "[v3,xx/20]Refactor the architecture parts of mt7628" >>>> >>>> Changes in v2: >>>> - Removed some dead code >>>> - Changed Author to my full name (no nick) >>>> - Removed unwanted fixup to .dts generation (not my call). >>>> - Fixed commit message >>>> - Fixed various variables/filenames to include Vendor name >>>> - Changed Vendor name (Vonger -> Vocore) >>>> >>>> arch/mips/dts/Makefile | 1 + >>>> arch/mips/dts/mt7628a.dtsi | 5 ++ >>>> arch/mips/dts/vocore_vocore2.dts | 78 ++++++++++++++++++++ >>>> arch/mips/mach-mtmips/Kconfig | 8 +++ >>>> board/vocore/vocore2/Kconfig | 12 ++++ >>>> board/vocore/vocore2/Makefile | 3 + >>>> board/vocore/vocore2/board.c | 6 ++ >>>> configs/vocore2_defconfig | 103 >>>> ++++++++++++++++++++++++++ >>>> configs/vocore2_defconfig_ENV_IN_FAT | 104 >>>> +++++++++++++++++++++++++++ >>>> include/configs/vocore2.h | 61 ++++++++++++++++ >>>> 10 files changed, 381 insertions(+) >>>> create mode 100644 arch/mips/dts/vocore_vocore2.dts >>>> create mode 100644 board/vocore/vocore2/Kconfig >>>> create mode 100644 board/vocore/vocore2/Makefile >>>> create mode 100644 board/vocore/vocore2/board.c >>>> create mode 100644 configs/vocore2_defconfig >>>> create mode 100644 configs/vocore2_defconfig_ENV_IN_FAT >>>> create mode 100644 include/configs/vocore2.h >>> >>> Apart from the other comments, the MAINTAINERS file is missing. Please >>> add it in the next patch version. >> Yes, I know. >> Also patman was complaining. >> I perused MAINTAINERS and it didn't look like specific board >> maintainers are in. >> I have no problems adding me to the list, but I'm unsure I have >> the privilege and it's unclear where I should add myself. > > I was not referring to the global MAINTAINERS file but the one located > in the board directory. Please see: > > board/gardena/smart-gateway-mt7688/MAINTAINERS Oops! I completely overlooked that. Done.
> Thanks, > Stefan Many Thanks Mauro
