Hi Simon, On 2/11/20 12:14 PM, Simon Glass wrote: > Hi Sean, > > On Mon, 10 Feb 2020 at 23:05, Sean Anderson <sean...@gmail.com> wrote: >> >> This type of bus is used in Linux to designate busses which have power > > buses > >> domains and/or clocks which need to be enabled before their child devices >> can be used. Because power domains are automatically enabled before >> probing in u-boot, we just need to enable any clocks present. > > U-Boot > >> >> Signed-off-by: Sean Anderson <sean...@gmail.com> >> --- > > With the above and below fixed: > > Reviewed-by: Simon Glass <s...@chromium.org> >
Will do, thanks. >> diff --git a/drivers/core/simple-pm-bus.c b/drivers/core/simple-pm-bus.c >> new file mode 100644 >> index 0000000000..3ee54531d1 >> --- /dev/null >> +++ b/drivers/core/simple-pm-bus.c >> @@ -0,0 +1,55 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Copyright (C) 2020 Sean Anderson <sean...@gmail.com> >> + */ >> + > > common.h > >> +#include <dm.h> >> +#include <clk.h> > > clk.h above dm.h > >> diff --git a/test/dm/simple-pm-bus.c b/test/dm/simple-pm-bus.c >> new file mode 100644 >> index 0000000000..1b42415ccd >> --- /dev/null >> +++ b/test/dm/simple-pm-bus.c >> @@ -0,0 +1,44 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2020 Sean Anderson <sean...@gmail.com> >> + */ >> + > > Please fix include ordering > > https://www.denx.de/wiki/U-Boot/CodingStyle Ah, I wasn't aware that there was a specific ordering; I had been doing it alphabetically. --Sean
