On Mon, 10 Feb 2020 at 23:05, Sean Anderson <sean...@gmail.com> wrote: > > This patch adds a generic reset driver. It is designed to be useful when > one has a register in a regmap which contains bits that reset other > devices. I thought this seemed like a very generic use, so here is a > generic driver. The overall structure has been modeled on the syscon-reboot > driver. > > Signed-off-by: Sean Anderson <sean...@gmail.com> > --- > > Changes in v4: > - Added basic test > - Fix incorrect usage of regmap_update_bits > > Changes in v3: > - New > > arch/sandbox/dts/test.dts | 15 ++++ > configs/sandbox_defconfig | 1 + > .../reset/syscon-reset.txt | 36 +++++++++ > drivers/reset/Kconfig | 5 ++ > drivers/reset/Makefile | 1 + > drivers/reset/reset-syscon.c | 79 +++++++++++++++++++ > test/dm/Makefile | 1 + > test/dm/syscon-reset.c | 58 ++++++++++++++ > 8 files changed, 196 insertions(+) > create mode 100644 doc/device-tree-bindings/reset/syscon-reset.txt > create mode 100644 drivers/reset/reset-syscon.c > create mode 100644 test/dm/syscon-reset.c
Please fix the include-file ordering fixed in the two .c files in this patch. Then: Reviewed-by: Simon Glass <s...@chromium.org>
