On 28.01.20 22:27, Denis 'GNUtoo' Carikli wrote: > On Tue, 28 Jan 2020 18:51:26 +0100 > Soeren Moch <sm...@web.de> wrote: > >> As already discussed, the bootm_size environment variable is not >> necessary, otherwise somewhat dangerous with this value. > Sorry, for the mistake, I've fixed it now. > > I'll send a v3 after some feedback from my response to your other > points. > > Thanks a lot for the reviews. For your v3 please drop patch 1/3, please disable CONFIG_GZIP instead. If you want to indicate the size reduction, please do so for u-boot.bin instead of u-boot.imx. And please only report the size reduction instead of absolute size values, as suggested by Fabio.
For patch 2/3 please include my Acked-by, and update size reduction description as suggested above. Please split patch 3/3 into 3 separate patches: - Move (the existing) CONFIG_BOOTCOMMAND to defconfig. - Enable DISTRO_DEFAULTS in defconfig, in preparation of distro_boot support. Also do the defconfig sync here. - Enable distro_boot support. This includes the modified BOOTCOMMAND, DEFAULT_FDT_FILE,BOOT_TARGET_DEVICES, and environment update. For all patches please also Cc: Stefano and Fabio. Thanks, Soeren
