On Sun, 26 Jan 2020 01:40:13 +0100 Soeren Moch <sm...@web.de> wrote: > >> Why do you define CONFIG_BOOTCOMMAND here instead of modifying the > >> existing one? > > I'm a bit confused with it: There seem to be many way to do the same > > thing and I'm not sure which one is the best. > > > > Because of that, I just kept it in the code as it was (instead of > > moving it to tbs2910_defconfig). > This is ok. What I mean: You moved it in the file, and therefore you > unnecessarily changed a lot of lines without actually changing most of > it's contents. If CONFIG_BOOTCOMMAND is not defined before, it will be defined in config_distro_bootcmd.h
This means that the order in which defines and #include <config_distro_bootcmd.h> is done matters. Which lead me to do the inclusion of config_distro_bootcmd.h as early as possible in the tbs2910.h. This way if there are some unintended redefinition due to things having changed in config_distro_bootcmd.h in the future, the compiler will at warn or error about it. Denis.
pgpEVVMpnVTij.pgp
Description: OpenPGP digital signature
