On Fri, Jan 24, 2020 at 1:36 PM Pragnesh Patel <pragnesh.pa...@sifive.com> wrote: > > > >-----Original Message----- > >From: Jagan Teki <ja...@amarulasolutions.com> > >Sent: 24 January 2020 11:58 > >To: Pragnesh Patel <pragnesh.pa...@sifive.com> > >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra > ><atish.pa...@wdc.com>; palmerdabb...@google.com; Bin Meng > ><bmeng...@gmail.com>; Paul Walmsley ( Sifive) > ><paul.walms...@sifive.com>; Troy Benjegerdes ( Sifive) > ><troy.benjeger...@sifive.com>; Anup Patel <anup.pa...@wdc.com>; Sagar > >Kadam <sagar.ka...@sifive.com>; Simon Glass <s...@chromium.org>; > >AKASHI Takahiro <takahiro.aka...@linaro.org>; Marek Behún > ><marek.be...@nic.cz>; Philippe Reynes <philippe.rey...@softathome.com>; > >Alexander Graf <ag...@csgraf.de>; Peng Fan <peng....@nxp.com> > >Subject: Re: [PATCH v3 03/10] lib: Makefile: build crc7.c when > >CONFIG_MMC_SPI > > > >On Fri, Jan 24, 2020 at 11:21 AM Pragnesh Patel <pragnesh.pa...@sifive.com> > >wrote: > >> > >> When build U-boot SPL, meet an issue of undefined reference to 'crc7' > >> for drivers/mmc/mmc_spi.c, so let's compile crc7.c when CONFIG_MMC_SPI > >> selected. > >> > >> Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com> > >> Reviewed-by: Anup Patel <anup.pa...@wdc.com> > >> --- > >> lib/Makefile | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/lib/Makefile b/lib/Makefile index 51eba80b89..d21e0a6b3a > >> 100644 > >> --- a/lib/Makefile > >> +++ b/lib/Makefile > >> @@ -78,6 +78,7 @@ endif > >> > >> ifdef CONFIG_SPL_BUILD > >> obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o > >> +obj-$(CONFIG_MMC_SPI) += crc7.o > > > >It is invalid to mark crc7 to MMC_SPI, try to add Kconfig option for CRC7. > >like > >this. > >https://paste.ubuntu.com/p/kSnkDWpTgS/ > > Thanks for pointing me. How about if I will add like this: > > config SPL_CRC7_SUPPORT > bool "Support CRC7 hashing drivers" > default y if MMC_SPI > help > Enable CRC7 hashing for drivers which are using in SPL. > > Any comments?
Make sense.
