On Wed, 2019-08-28 at 15:57 +0200, Stefan Roese wrote:
> On 28.08.19 08:38, Weijie Gao wrote:
> > This patch changes all defconfig files of mtmips to use mtk high-speed
> > uart driver.
> >
> > This driver is compatible with ns16550a when baudrate <= 115200.
> >
> > Signed-off-by: Weijie Gao <weijie....@mediatek.com>
>
> As already suggested by Daniel, please move this change into a Kconfig
> "select"
> instead in the arch/mips platform.
>
> Thanks,
> Stefan
>
> > ---
> > configs/gardena-smart-gateway-mt7688-ram_defconfig | 2 +-
> > configs/gardena-smart-gateway-mt7688_defconfig | 2 +-
> > configs/linkit-smart-7688-ram_defconfig | 2 +-
> > configs/linkit-smart-7688_defconfig | 2 +-
> > include/configs/gardena-smart-gateway-mt7688.h | 2 +-
> > include/configs/linkit-smart-7688.h | 2 +-
> > 6 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/configs/gardena-smart-gateway-mt7688-ram_defconfig
> > b/configs/gardena-smart-gateway-mt7688-ram_defconfig
> > index 1a1167b2a6..99010289e9 100644
> > --- a/configs/gardena-smart-gateway-mt7688-ram_defconfig
> > +++ b/configs/gardena-smart-gateway-mt7688-ram_defconfig
> > @@ -68,7 +68,7 @@ CONFIG_POWER_DOMAIN=y
> > CONFIG_RAM=y
> > CONFIG_DM_RESET=y
> > # CONFIG_SPL_SERIAL_PRESENT is not set
> > -CONFIG_SYS_NS16550=y
> > +CONFIG_MTK_SERIAL=y
> > CONFIG_SPI=y
> > CONFIG_MT7621_SPI=y
> > CONFIG_SYSRESET_SYSCON=y
> > diff --git a/configs/gardena-smart-gateway-mt7688_defconfig
> > b/configs/gardena-smart-gateway-mt7688_defconfig
> > index a456e3b575..1e270cb61d 100644
> > --- a/configs/gardena-smart-gateway-mt7688_defconfig
> > +++ b/configs/gardena-smart-gateway-mt7688_defconfig
> > @@ -71,7 +71,7 @@ CONFIG_POWER_DOMAIN=y
> > CONFIG_RAM=y
> > CONFIG_DM_RESET=y
> > # CONFIG_SPL_SERIAL_PRESENT is not set
> > -CONFIG_SYS_NS16550=y
> > +CONFIG_MTK_SERIAL=y
> > CONFIG_SPI=y
> > CONFIG_MT7621_SPI=y
> > CONFIG_SYSRESET_SYSCON=y
> > diff --git a/configs/linkit-smart-7688-ram_defconfig
> > b/configs/linkit-smart-7688-ram_defconfig
> > index aa76633802..1e9cac5596 100644
> > --- a/configs/linkit-smart-7688-ram_defconfig
> > +++ b/configs/linkit-smart-7688-ram_defconfig
> > @@ -55,7 +55,7 @@ CONFIG_POWER_DOMAIN=y
> > CONFIG_RAM=y
> > CONFIG_DM_RESET=y
> > # CONFIG_SPL_SERIAL_PRESENT is not set
> > -CONFIG_SYS_NS16550=y
> > +CONFIG_MTK_SERIAL=y
> > CONFIG_SPI=y
> > CONFIG_MT7621_SPI=y
> > CONFIG_SYSRESET_SYSCON=y
> > diff --git a/configs/linkit-smart-7688_defconfig
> > b/configs/linkit-smart-7688_defconfig
> > index 3750e59a4b..743cc48166 100644
> > --- a/configs/linkit-smart-7688_defconfig
> > +++ b/configs/linkit-smart-7688_defconfig
> > @@ -59,7 +59,7 @@ CONFIG_POWER_DOMAIN=y
> > CONFIG_RAM=y
> > CONFIG_DM_RESET=y
> > # CONFIG_SPL_SERIAL_PRESENT is not set
> > -CONFIG_SYS_NS16550=y
> > +CONFIG_MTK_SERIAL=y
> > CONFIG_SPI=y
> > CONFIG_MT7621_SPI=y
> > CONFIG_SYSRESET_SYSCON=y
> > diff --git a/include/configs/gardena-smart-gateway-mt7688.h
> > b/include/configs/gardena-smart-gateway-mt7688.h
> > index b3b89d2ab9..e83a96ad5e 100644
> > --- a/include/configs/gardena-smart-gateway-mt7688.h
> > +++ b/include/configs/gardena-smart-gateway-mt7688.h
> > @@ -22,7 +22,7 @@
> >
> > /* UART */
> > #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200, \
> > - 230400, 500000, 1500000 }
> > + 230400, 460800, 921600 }
> >
> > /* RAM */
> > #define CONFIG_SYS_MEMTEST_START 0x80100000
> > diff --git a/include/configs/linkit-smart-7688.h
> > b/include/configs/linkit-smart-7688.h
> > index 2adf38545a..4d30d98abf 100644
> > --- a/include/configs/linkit-smart-7688.h
> > +++ b/include/configs/linkit-smart-7688.h
> > @@ -22,7 +22,7 @@
> >
> > /* UART */
> > #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200, \
> > - 230400, 500000, 1500000 }
> > + 230400, 460800, 921600 }
> >
> > /* RAM */
> > #define CONFIG_SYS_MEMTEST_START 0x80100000
> >
>
> Viele Grüße,
> Stefan
>
Actually both ns16550a and mtk-hsuart can be used.
But it's OK to force to use mtk-hsuart.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
