On Sun, 18 Aug 2019 17:16:06 +0200 Jonas Smedegaard <d...@jones.dk> wrote:
> commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to
> Kconfig") intended to support CONFIG_PREBOOT, but
> include/configs/sunxi-common.h hardcodes preboot as part of internally
> defined CONSOLE_STDIN_SETTINGS, silently ignoring any board-specific
> CONFIG_PREBOOT.
>
> Tested-by: Jonas Smedegaard <d...@jones.dk>
> Signed-off-by: Jonas Smedegaard <d...@jones.dk>
> Series-Cc: Jagan Teki <ja...@amarulasolutions.com>
> ---
>
> include/configs/sunxi-common.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/sunxi-common.h
> b/include/configs/sunxi-common.h index d7133a73fc..2069884b63 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -432,8 +432,13 @@ extern int soft_i2c_gpio_scl;
> #include <config_distro_bootcmd.h>
>
> #ifdef CONFIG_USB_KEYBOARD
> +#ifdef CONFIG_USE_PREBOOT
> +#ifndef CONFIG_PREBOOT
> +#define CONFIG_PREBOOT \
> + "usb start"
Shouldn't this (CONFIG_PREBOOT) be set in the Kconfig?
> +#endif
> +#endif
> #define CONSOLE_STDIN_SETTINGS \
> - "preboot=usb start\0" \
> "stdin=serial,usbkbd\0"
> #else
> #define CONSOLE_STDIN_SETTINGS \
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpyGh1W4EsWY.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
