Hi Stefano, On Thu, Aug 1, 2019, 16:19 Stefano Babic <sba...@denx.de> wrote:
> On 24/07/19 14:19, Igor Opaniuk wrote: > > Hi Stefan > > > > On Wed, Jul 24, 2019 at 2:32 PM Stefan Agner <ste...@agner.ch> wrote: > >> > >> On 2019-07-03 15:50, Igor Opaniuk wrote: > >>> From: Igor Opaniuk <igor.opan...@toradex.com> > >>> > >>> NXP downstream kernel uses legacy method to enable other cores, > >>> which requires kernel to run in a security mode (althought upstream > kernel > >>> uses PSCI for this). > >>> > >>> As we're using NXP kernel in our BSPs, lets enable this by default. > >> > >> I think I mentioned it internally, but just to be clear: I do not agree > >> with this patch. > >> > >> Upstream U-Boot should be able to boot upstream Linux. I'd rather prefer > >> to carry that patch in our downstream fork (or set the bootm_boot_mode > >> environment in our boot script). > > > > Totally agree with you here, > > BTW, seems that Stefano has applied by mistake to u-boot-imx > > fcc79eee14("colibri_imx7_emmc: enable CONFIG_ARMV7_BOOT_SEC_DEFAULT"), > > although I've asked to ignore it. > > Sorry for this - I have taken a look and I drop this one but I took > fcc79eee14. Should I simply revert it on u-boot-imx (you do not need to > send a patch, then)? > Yes, please revert this patch, as it brakes boot of the mainline kernel. Thanks! > Regards, > Stefano > > > > > Probably will send another patch that reverts this. > > > >> > >> -- > >> Stefan > >> > >>> > >>> Signed-off-by: Igor Opaniuk <igor.opan...@toradex.com> > >>> --- > >>> > >>> include/configs/colibri_imx7.h | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/include/configs/colibri_imx7.h > b/include/configs/colibri_imx7.h > >>> index 40173b18fa..5408577661 100644 > >>> --- a/include/configs/colibri_imx7.h > >>> +++ b/include/configs/colibri_imx7.h > >>> @@ -164,7 +164,8 @@ > >>> "${board}/flash_blk.img && source ${loadaddr}\0" \ > >>> "setup=setenv setupargs " \ > >>> "console=tty1 console=${console}" \ > >>> - ",${baudrate}n8 ${memargs} consoleblank=0\0" \ > >>> + ",${baudrate}n8 ${memargs} consoleblank=0; " \ > >>> + "setenv bootm_boot_mode sec\0" \ > >>> "setupdate=run setsdupdate || run setusbupdate || run > setethupdate\0" \ > >>> "setusbupdate=usb start && setenv interface usb && " \ > >>> "fatload ${interface} 0:1 ${loadaddr} " \ > > > > > > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de > ===================================================================== > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot