Hi Lokesh, On 7/29/19 11:08 PM, Lokesh Vutla wrote: > > > On 29/07/19 10:18 PM, Suman Anna wrote: >> The K3 System Controller driver is used for loading and starting >> the System Firmware, and is used only on R5 SPL. It need not be >> enabled and built for the A53 U-Boot and SPL, so disable it from >> both the GP and HS AM65x A53 defconfigs. >> >> While at this, also remove the unneeded CONFIG_SPL_REMOTEPROC and >> CONFIG_CMD_REMOTEPROC as no remoteprocs are now loaded from A53 SPL. >> >> Signed-off-by: Suman Anna <s-a...@ti.com> >> --- >> configs/am65x_evm_a53_defconfig | 3 --- >> configs/am65x_hs_evm_a53_defconfig | 3 --- >> 2 files changed, 6 deletions(-) >> >> diff --git a/configs/am65x_evm_a53_defconfig >> b/configs/am65x_evm_a53_defconfig >> index 2cf3a693fc70..d43df6a18765 100644 >> --- a/configs/am65x_evm_a53_defconfig >> +++ b/configs/am65x_evm_a53_defconfig >> @@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y >> CONFIG_SPL_DM_MAILBOX=y >> CONFIG_SPL_DM_RESET=y >> CONFIG_SPL_POWER_DOMAIN=y >> -CONFIG_SPL_REMOTEPROC=y >> CONFIG_SPL_YMODEM_SUPPORT=y >> CONFIG_CMD_ASKENV=y >> # CONFIG_CMD_FLASH is not set >> CONFIG_CMD_GPT=y >> CONFIG_CMD_I2C=y >> CONFIG_CMD_MMC=y >> -CONFIG_CMD_REMOTEPROC=y > > CMD_REMOTEPROC will definitely be used in very near future. Please retain > this. > Rest looks good to me.
This is a result of using savedefconfig, I prefer it this way since it allows other developers adding options to do it cleanly. If and when a REMOTEPROC is enabled, the savedefconfig with corresponding options should automatically bring this back. regards Suman > > Thanks and regards, > Lokesh > >> # CONFIG_CMD_SETEXPR is not set >> CONFIG_CMD_TIME=y >> # CONFIG_ISO_PARTITION is not set >> @@ -79,7 +77,6 @@ CONFIG_SPL_PINCTRL=y >> CONFIG_PINCTRL_SINGLE=y >> CONFIG_POWER_DOMAIN=y >> CONFIG_TI_SCI_POWER_DOMAIN=y >> -CONFIG_K3_SYSTEM_CONTROLLER=y >> CONFIG_DM_RESET=y >> CONFIG_RESET_TI_SCI=y >> CONFIG_DM_SERIAL=y >> diff --git a/configs/am65x_hs_evm_a53_defconfig >> b/configs/am65x_hs_evm_a53_defconfig >> index 48b28b390ef1..8ac16f0372e4 100644 >> --- a/configs/am65x_hs_evm_a53_defconfig >> +++ b/configs/am65x_hs_evm_a53_defconfig >> @@ -31,13 +31,11 @@ CONFIG_SPL_I2C_SUPPORT=y >> CONFIG_SPL_DM_MAILBOX=y >> CONFIG_SPL_DM_RESET=y >> CONFIG_SPL_POWER_DOMAIN=y >> -CONFIG_SPL_REMOTEPROC=y >> CONFIG_SPL_YMODEM_SUPPORT=y >> CONFIG_CMD_ASKENV=y >> # CONFIG_CMD_FLASH is not set >> CONFIG_CMD_I2C=y >> CONFIG_CMD_MMC=y >> -CONFIG_CMD_REMOTEPROC=y >> # CONFIG_CMD_SETEXPR is not set >> CONFIG_CMD_TIME=y >> # CONFIG_ISO_PARTITION is not set >> @@ -76,7 +74,6 @@ CONFIG_SPL_PINCTRL=y >> CONFIG_PINCTRL_SINGLE=y >> CONFIG_POWER_DOMAIN=y >> CONFIG_TI_SCI_POWER_DOMAIN=y >> -CONFIG_K3_SYSTEM_CONTROLLER=y >> CONFIG_DM_RESET=y >> CONFIG_RESET_TI_SCI=y >> CONFIG_DM_SERIAL=y >> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot