Dear Chuanhua, In message <20190724025904.469-2-chuanhua....@nxp.com> you wrote: > This patch is updating ls2088aqds board init code to support DM_I2C.
I have a generic question about error handling in your code: > + a = 0x18; > + dm_i2c_write(udev, 6, &a, 1); > + a = 0x38; > + dm_i2c_write(udev, 4, &a, 1); > + a = 0x4; > + dm_i2c_write(udev, 8, &a, 1); > + > + dm_i2c_write(udev, 0xf, &ch_a_eq[i], 1); > + dm_i2c_write(udev, 0x11, &ch_a_ctl2[j], 1); > + > + dm_i2c_write(udev, 0x16, &ch_b_eq[i], 1); > + dm_i2c_write(udev, 0x18, &ch_b_ctl2[j], 1); > + > + a = 0x14; > + dm_i2c_write(udev, 0x23, &a, 1); > + a = 0xb5; > + dm_i2c_write(udev, 0x2d, &a, 1); > + a = 0x20; > + dm_i2c_write(udev, 4, &a, 1); ... > i2c_write(0x77, 0, 0, &a, 1); ... You use a large number of functions without ever checking their return codes. But all these functions can fail for a number of reasons. Should you not always check for errors? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He had quite a powerful intellect, but it was as powerful like a locomotive, and ran on rails and was therefore almost impossible to steer. - Terry Pratchett, _Lords and Ladies_ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
