On Sun, Jun 30, 2019 at 02:45:01AM +0100, Andre Przywara wrote: > At the moment mkenvimage has two separate read paths: One to read from > a potential pipe, while dynamically increasing the buffer size, and a > second one using mmap(2), using the input file's size. This is > problematic for two reasons: > - The "pipe" path will be chosen if the input filename is missing or > "-". Any named, but non-regular file will use the other path, which > typically will cause mmap() to fail: > $ mkenvimage -s 256 -o out <(echo "foo=bar") > - There is no reason to have *two* ways of reading a file, since the > "pipe way" will always work, even for regular files. > > Fix this (and simplify the code on the way) by always using the method > of dynamically resizing the buffer. The existing distinction between > the two cases will merely be used to use the open() syscall or not. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
