On 06/10/2010 02:46 PM, Simon Kagstrom wrote:
On Thu, 10 Jun 2010 14:42:24 +0530
Tanmay Upadhyay<tanmay.upadh...@einfochips.com> wrote:
This patch modifies existing OpenRD-Base support to deal with all
the three OpenRD boards (OpenRD-Base, OpenRD-Client& OpenRD-Ultimate).
Yes, that's a good change!
diff --git a/arch/arm/include/asm/mach-types.h
b/arch/arm/include/asm/mach-types.h
index 940d814..19114b0 100644
--- a/arch/arm/include/asm/mach-types.h
+++ b/arch/arm/include/asm/mach-types.h
@@ -2862,6 +2862,7 @@ extern unsigned int __machine_arch_type;
#define MACH_TYPE_MATRIX518 2879
#define MACH_TYPE_TINY_GURNARD 2880
#define MACH_TYPE_SPEAR1310 2881
+#define MACH_TYPE_OPENRD_ULTIMATE 2884
I don't think this file is supposed to be edited in patches, but rather
synched from arm-linux by Wolfgang from time to time.
Sorry, I didn't know about that. However, as the number is already
registered, is that ok to have it here?
diff --git a/include/configs/openrd_client.h b/include/configs/openrd_client.h
new file mode 100644
index 0000000..d936ffa
Perhaps common parts of this...
diff --git a/include/configs/openrd_ultimate.h
b/include/configs/openrd_ultimate.h
new file mode 100644
index 0000000..a0e0417
and this and openrd_base.h can be merged into a common file. Most stuff
should be identical, right?
I agree with you. But auto-generated 'config.h' file includes
<board_name.h>. So there has to be one for each board. However, there
could be one 'openrd.h' in the configs and three board specific files
include it. This will increase the number of files, but would decrease
LOC. What do you think?
Thanks,
Tanmay
// Simon
Email Scanned for Virus& Dangerous Content by : www.CleanMailGateway.com
____________________________________________________________________________________
Disclaimer: This e-mail message and all attachments transmitted with it are
intended solely for the use of the addressee and may contain legally privileged
and confidential information. If the reader of this message is not the intended
recipient, or an employee or agent responsible for delivering this message to
the intended recipient, you are hereby notified that any dissemination,
distribution, copying, or other use of this message or its attachments is
strictly prohibited. If you have received this message in error, please notify
the sender immediately by replying to this message and please delete it from
your computer. Any views expressed in this message are those of the individual
sender unless otherwise stated.Company has taken enough precautions to prevent
the spread of viruses. However the company accepts no liability for any damage
caused by any virus transmitted by this email.
____________________________________________________________________________________
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
