Hello Andre, Am Sonntag, 30. Juni 2019, 02:45:00 CEST schrieb Andre Przywara: > It is perfectly fine for the read(2) syscall to return with less than > the requested number of bytes read (short read, see the "RETURN VALUE" > section of the man page). This typically happens with slow input > (keyboard, network) or with complex pipes. > > So far mkenvimage expects the exact number of requested bytes to be > read, assuming an end-of-file condition otherwise. This wrong behaviour > can be easily shown with: > $ (echo "foo=bar"; sleep 1; echo "bar=baz") | mkenvimage -s 256 -o out - > The second line will be missing from the output. > > Correct this by checking for any positive, non-zero return value. > > This fixes a problem with a complex pipe in one of my scripts, where > the environment consist of two parts. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
From reading the code and 'man 2 read' again, not tested locally: Acked-by: Alexander Dahl <a...@thorsis.com> Greets Alex _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
