On 6/21/19 3:26 PM, Patrick Delaunay wrote:
> This patch solves the following warnings:
>
> drivers/adc/stm32-adc.c: In function 'stm32_adc_chan_of_init':
> warning: comparison between signed and unsigned integer expressions
> [-Wsign-compare]
> if (num_channels > adc->cfg->max_channels) {
> ^
> Signed-off-by: Patrice Chotard <patrice.chot...@st.com>
>
> Signed-off-by: Patrick Delaunay <patrick.delau...@st.com>
Hi Patrick,
Acked-by: Fabrice Gasnier <fabrice.gasn...@st.com>
Thanks,
Fabrice
> ---
>
> drivers/adc/stm32-adc.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/adc/stm32-adc.c b/drivers/adc/stm32-adc.c
> index e108062..029338e 100644
> --- a/drivers/adc/stm32-adc.c
> +++ b/drivers/adc/stm32-adc.c
> @@ -163,15 +163,16 @@ static int stm32_adc_chan_of_init(struct udevice *dev)
> struct adc_uclass_platdata *uc_pdata = dev_get_uclass_platdata(dev);
> struct stm32_adc *adc = dev_get_priv(dev);
> u32 chans[STM32_ADC_CH_MAX];
> - int i, num_channels, ret;
> + unsigned int i, num_channels;
> + int ret;
>
> /* Retrieve single ended channels listed in device tree */
> - num_channels = dev_read_size(dev, "st,adc-channels");
> - if (num_channels < 0) {
> - dev_err(dev, "can't get st,adc-channels: %d\n", num_channels);
> - return num_channels;
> + ret = dev_read_size(dev, "st,adc-channels");
> + if (ret < 0) {
> + dev_err(dev, "can't get st,adc-channels: %d\n", ret);
> + return ret;
> }
> - num_channels /= sizeof(u32);
> + num_channels = ret / sizeof(u32);
>
> if (num_channels > adc->cfg->max_channels) {
> dev_err(dev, "too many st,adc-channels: %d\n", num_channels);
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
