Dear Timur Tabi, In message <aanlktilji5knon3qd_58dy7xpegviiibe1qy0gxoq...@mail.gmail.com> you wrote: > > So here's a better version of that function that rounds to the nearest > MHz and is of a proper coding style:
Why do we need that? > And the result: > > Clock Configuration: > CPU0:800 MHz, CPU1:800 MHz, > CCB:400 MHz, > DDR:300 MHz (600 MT/s data rate) (Asynchronous), LBC:25 MHz The result looks ugly (why do we have double spaces after the numbers?, why do the numbers not align vertically?). This makes me wonder why you use a "%-4s" format in arch/powerpc/cpu/mpc8?xx/cpu.c - may I recommend changing this into "%s" (if you don't care about vertical alignment), or something like "%4s" else? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is surely a great calamity for a human being to have no ob- sessions. - Robert Bly _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
