> -----Original Message----- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Thursday, May 06, 2010 4:20 PM > To: Nishanth Menon > Cc: Hiremath, Vaibhav; u-boot@lists.denx.de > Subject: Re: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support > > Dear Nishanth Menon, > > In message <u2h782515bb1005060340o3b366389mfdb71c240cbc7...@mail.gmail.com> > you wrote: > > On Thu, May 6, 2010 at 12:36 AM, Hiremath, Vaibhav <hvaib...@ti.com> > wrote: > ... > > > I do agree that we don't have to undef here, but agreed to Nishant's > comment only because from user point of view, if user would > > > like to enable ONENAND support then for him it's easy he just have to > comment NAND line and make change this #define. He > > > doesn't have to dig inside code to find out whether ONENAND is supported > or not. > > Well, of course the user _has_ to dig into the code and check if the > feature is supported, because there is no information what the > "#undef" or the comment means - it can mean anything: > > - disabled here and left in so you can easily re-add it if you like > - disabled because known to be unsupported or broken > - disabled because untested > - ... [Hiremath, Vaibhav] Ok. Agreed. I will remove undef line and submit the patch.
Thanks, Vaibhav > > > platforms such as SDP platforms have three flash devices - nand, > > onenand and nor - these are development platforms and are meant to > > bootup from any of these devices based on which ever dip switch is > > set. having a #undef is more elegant than /* */ and easier to use from > > a developer perspective. > > Please provide one working configuration, or several config options, > but don't try to add kind of configuration menues using "#define" / > "#undef" lists. These are useless and confusing at best. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Motto of the Electrical Engineer: Working computer hardware is a lot > like an erect penis: it stays up as long as you don't fuck with it. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
