Hello Igor, All, On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote: > Hi Eugeniu, > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca <roscaeuge...@gmail.com> wrote: [..] > > > > The s/uint8_t/u8/ and s/uint32_t/u32/ conversion creates noise > > comparing the in-tree versus out-of-tree files and will add some > > overhead during integration. I still see a lot of U-Boot code saying > > uint8_t/uint32_t, so I wonder if these can be preserved. BTW, some of > > the patches from this series add code using uint32_t. > > Agree.
Igor, many thanks for the recent replies. WRT preserving the contents of the original bootloader_message.h from https://android.googlesource.com/platform/bootable/recovery.git/ , I wonder what's the chance of keeping the CPP comments in place when importing the file in-tree, since it will make the diffs and subsequent integration/updates easier from the source repository. Furthermore, we don't expect any U-Boot specific development to be done in this file in-tree. It should purely reflect the upstream state. I wonder if there is any official position regarding that from the U-Boot maintainers? FTR/FWIW, there are around 24 .c/.h files in U-Boot master, carrying CPP comments (SDPX identifiers carefully excluded): $ git grep "^\s*//\s" -- "*.c" "*.h" | grep -v "SPDX" | awk '{print $1}' | sort -u | cut -d ':' -f 1 arch/arm/mach-tegra/board2.c arch/riscv/include/asm/encoding.h arch/xtensa/include/asm/arch-dc233c/tie-asm.h arch/xtensa/include/asm/arch-de212/tie-asm.h board/freescale/lx2160a/eth_lx2160aqds.c board/renesas/blanche/qos.c board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c board/xilinx/zynq/zynq-zed/ps7_init_gpl.c drivers/video/stb_truetype.h drivers/video/stb_truetype.h fs/ubifs/ubifs.h include/efi_api.h include/linux/mtd/flashchip.h include/linux/mtd/mtd.h lib/efi_loader/efi_hii.c lib/efi_selftest/efi_selftest_crc32.c lib/efi_selftest/efi_selftest_hii_data.c lib/libavb/avb_slot_verify.c scripts/kconfig/expr.c scripts/kconfig/gconf.c scripts/kconfig/qconf.h tools/mingw_support.c > > > Thanks and best regards, > > Eugeniu. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
