On Wed, Feb 13, 2019 at 09:13:05PM +0100, Heinrich Schuchardt wrote:

> The SPL image for the rk3288 boards has to fit into 32 KiB. This includes
> 4 KiB for the device tree and up to 2 KiB for the file header.
> 
> Without the patch we missed to see that the TinkerBoard
> spl/u-boot-spl-dtb.bin file is too big.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>

NAK.  To repeat myself in what I said after this patch was already sent,
but for the record, we need to leverage CONFIG_SPL_MAX_SIZE (and
CONFIG_TPL_MAX_SIZE) with the BOARD_SIZE_CHECK logic (and use said logic
more widely) so that we catch this problem everywhere.  A guess at max
DTB size is not enough.  Thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to