> -----Original Message----- > From: Simon Goldschmidt [mailto:simon.k.r.goldschm...@gmail.com] > Sent: Friday, January 4, 2019 5:46 PM > To: Ooi, Joyce <joyce....@intel.com> > Cc: Marek Vasut <ma...@denx.de>; Michal Simek <michal.si...@xilinx.com>; > Siva Durga Prasad Paladugu <siva.durga.palad...@xilinx.com>; u- > b...@lists.denx.de; Chee, Tien Fong <tien.fong.c...@intel.com>; See, Chin > Liang <chin.liang....@intel.com> > Subject: Re: [U-Boot] [PATCH] rsa: read out public_exponent value based on 32- > bit alignment > > On Fri, Jan 4, 2019 at 10:36 AM Ooi, Joyce <joyce....@intel.com> wrote: > > > > > -----Original Message----- > > > From: Simon Goldschmidt [mailto:simon.k.r.goldschm...@gmail.com] > > > Sent: Saturday, December 29, 2018 5:04 AM > > > To: Marek Vasut <ma...@denx.de>; Ooi, Joyce <joyce....@intel.com>; > > > Michal Simek <michal.si...@xilinx.com>; Siva Durga Prasad Paladugu > > > <siva.durga.palad...@xilinx.com> > > > Cc: u-boot@lists.denx.de; Chee, Tien Fong > > > <tien.fong.c...@intel.com>; See, Chin Liang > > > <chin.liang....@intel.com> > > > Subject: Re: [U-Boot] [PATCH] rsa: read out public_exponent value > > > based on 32- bit alignment > > > > > > Am 28.12.2018 um 19:44 schrieb Marek Vasut: > > > > On 12/28/18 2:32 PM, Ooi, Joyce wrote: > > > >>> -----Original Message----- > > > >>> From: Marek Vasut [mailto:ma...@denx.de] > > > >>> Sent: Friday, December 28, 2018 6:05 PM > > > >>> To: Ooi, Joyce <joyce....@intel.com>; Michal Simek > > > >>> <michal.si...@xilinx.com>; Siva Durga Prasad Paladugu > > > >>> <siva.durga.palad...@xilinx.com> > > > >>> Cc: u-boot@lists.denx.de; See, Chin Liang > > > >>> <chin.liang....@intel.com>; Chee, Tien Fong > > > >>> <tien.fong.c...@intel.com>; Tan, Ley Foon > > > >>> <ley.foon....@intel.com> > > > >>> Subject: Re: [PATCH] rsa: read out public_exponent value based > > > >>> on 32-bit alignment > > > >>> > > > >>> On 12/28/18 8:30 AM, Ooi, Joyce wrote: > > > >>>> Hi Marek, > > > >>> > > > >>> Hi, > > > >>> > > > >>>> Any comments about this? > > > >>> > > > >>> Use get_unaligned() ? > > > >> It seems that if USE_HOSTCC is enabled, get_unaligned_* can't be used. > > > > > > > > Can this be fixed ? > > > > > > I was working on a patch (or series?) to make USE_HOSTCC more generic > (i.e. > > > concentrate the HOSTCC specific things in some header files, > > > hopefully) as I have stumbled accross this when adding > > > compression/uncompression to mkimage, but I haven't found the time > > > to complete this, yet. > > > > > > Nevertheless, I think this is where we should go, rather then add > > > yet more #ifdef USE_HOSTCC to C files... > > > > > > Regards, > > > Simon > > Can you please help to fix this, Simon? I'm not too familiar with > > USE_HOSTCC.. > > I'm not there, yet, unfortunately. I don't have too much time for U-Boot right > now and my current work is getting of-platdata to run. > > So it might be a few weeks until I can continue working on that. No worries. Do let me know when you've worked on it.
Thanks! > > Regards, > Simon > > > Thanks. > > > > > > > > > > > > >> In lib/rsa/rsa-mod-exp.c, > > > >> #ifndef USE_HOSTCC > > > >> .. > > > >> #include <asm/unaligned.h> > > > >> #else > > > >> #include "fdt_host.h" > > > >> #include "mkimage.h" > > > >> #include <fdt_support.h> > > > >> #endif > > > >> > > > >> So, to make it more generic (with or without USE_HOSTCC enabled), > > > >> I read out the public_exponent as two 32-bit datas and then > > > >> concatenating them into a 64-bit data. > > > > > > > > See above -- I'd much rather see the get_unaligned() fixed and used. > > > > > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
