On 4/21/2010 5:21 PM, Peter Tyser wrote: > Hi Vipin, > > On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote: >> Adding CONFIG_DISPLAY_CPUINFO and CONFIG_ARCH_CPU_INIT support for SPEAr3xx >> and >> SPEAr6xx SoCs >> >> Signed-off-by: Vipin Kumar <vipin.ku...@st.com> >> --- >> arch/arm/cpu/arm926ejs/spear/Makefile | 3 +- >> arch/arm/include/asm/arch-spear/spr_misc.h | 5 ++ >> cpu/arm926ejs/spear/cpu_info.c | 76 >> ++++++++++++++++++++++++++++ > > The cpu path above needs to be adjusted to arch/arm/cpu/... > Yes, I would do that in patch v2
> Also, cpu_info.c doesn't seem like the best filename. You put both > initialization code and informational code in it, so a more generic name > such as "cpu.c" would be preferred. Or possibly cpu.c and cpu_init.c. > PowerPC boards would serve as a decent reference. > Yes, I just thought about it sometime back and then forgot to change the name. I would change the name to cpu.c > Best, > Peter > Thanks Vipin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
